VIDSOL-284: UI/UX - Meeting Room #284
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OscarFava
changed the title
…colors and updated UI elements
… for improved styling and layout
…r to match new theme
…s for improved consistency and visual appeal
…d InputAudioDevices and OutputAudioDevices components with tests
…ency and update styles with new theme colors
There was a problem hiding this comment.
Pull request overview
This PR implements UI/UX improvements for the Meeting Room by migrating from Tailwind CSS to Material-UI (MUI) components and applying a new design system based on semantic tokens.
Key changes:
- Migration from Tailwind CSS classes to MUI's sx prop and Box components
- Replacement of MUI icons with VividIcon components
- Implementation of semantic color tokens from the theme system
Reviewed changes
Copilot reviewed 98 out of 108 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/ui/src/MenuList/* | Adds MenuList wrapper component for MUI |
| frontend/src/pages/MeetingRoom/MeetingRoom.tsx | Converts root container from div to Box with MUI styling |
| frontend/src/designTokens/tokens/color.ts | Adds new semantic color tokens for dark theme variants |
| frontend/src/components/WaitingRoom/Button/.tsx | Updates hover colors to use semantic tokens |
| frontend/src/components/Subscriber/Subscriber.tsx | Converts Tailwind classes to inline styles with theme values |
| frontend/src/components/SoundTest/SoundTest.tsx | Wraps text in Typography and adds hover styling |
| frontend/src/components/ScreenSharingButton/ScreenSharingButton.tsx | Replaces MUI icons with VividIcon |
| frontend/src/components/MeetingRoom/* | Comprehensive migration of all meeting room components to MUI Box/Typography with semantic tokens |
| frontend/src/components/Icons/PushPinOffIcon/PushPinOffIcon.tsx | Updates icon imports to use wrapped UI components |
| frontend/src/Context/Theme/helpers/getMuiCustomTheme.ts | Adds Dialog component styling overrides |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frontend/src/components/MeetingRoom/ScreenSharePublisher/ScreenSharePublisher.tsx
Show resolved
Hide resolved
frontend/src/components/MeetingRoom/DeviceControlButton/DeviceControlButton.tsx
Show resolved
Hide resolved
…VideoDevices, and ReportIssueButton components for improved styling and consistency; update Box keys and fix inline styles in tests
…yling; adjust icon color logic and margin properties for better layout consistency
|
…age' into vidsol-284-meeting-room
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This PR is modifying the UI of the Meeting room according to the proposal of the design team. It also includes:
Wrap MUI components into our own library (UI).
Modify tailwind to MUI.
Use the semantic tokens.
How should this be manually tested?
Check visual changes in the Meeting Room page.
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDSOL-284
Checklist
[X] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?